feat: Enhance registry definition rendering to support RegDef V2 #725
+35
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BackendBits
requested review from
GlimmerCape,
chethana-shastry-p and
miyamuraga
as code owners
BackendBits
force-pushed
the
feature/support_registry_v2
branch
from
a6693fd to
b04afb2
Compare
netcracker-pr-bypass-rule
bot
requested a review
from andyroode
as a code owner
BackendBits
force-pushed
the
feature/support_registry_v2
branch
from
b94b0be to
fa5b13c
Compare
BackendBits
force-pushed
the
feature/support_registry_v2
branch
3 times, most recently
from
eafc0d4 to
8c65959
Compare
BackendBits
force-pushed
the
feature/support_registry_v2
branch
from
8c65959 to
ee1ec14
Compare
miyamuraga
changed the title
miyamuraga
requested changes
Dec 2, 2025
Collaborator
miyamuraga
left a comment
miyamuraga
left a comment
There was a problem hiding this comment.
Several issues need to be resolved
BackendBits
force-pushed
the
feature/support_registry_v2
branch
from
ee1ec14 to
42ad537
Compare
BackendBits
force-pushed
the
feature/support_registry_v2
branch
from
42ad537 to
e30aaa2
Compare
BackendBits
added a commit
to BackendBits/qubership-envgene
that referenced
this pull request
Dec 2, 2025
- Replace print() with logger in main.py validation - Add schema path constants (APPDEF_SCHEMA, REGDEF_V1_SCHEMA, REGDEF_V2_SCHEMA) - Remove redundant validate_regdef_v2_authconfig() function - Convert multi-line docstrings to single line in artifact searcher - Use debug level for schema selection logging Addresses same style issues flagged in PR Netcracker#725 review.
BackendBits
force-pushed
the
feature/support_registry_v2
branch
2 times, most recently
from
b78c13b to
85ff274
Compare
BackendBits
force-pushed
the
feature/support_registry_v2
branch
2 times, most recently
from
8a1af0f to
f7086ac
Compare
miyamuraga
approved these changes
Dec 18, 2025
BackendBits
force-pushed
the
feature/support_registry_v2
branch
from
3c5f97f to
433b3fa
Compare
BackendBits
force-pushed
the
feature/support_registry_v2
branch
from
433b3fa to
f8431c1
Compare
Detect version field in RegDef files and validate against V2 schema when version is 2.0. Use logger for validation messages and move schema paths to constants.
BackendBits
force-pushed
the
feature/support_registry_v2
branch
from
f8431c1 to
41d25bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Add RegDef V2 validation with version detection. Automatically routes to V2 schema when
version: "2.0"is present, maintaining full backward compatibility with V1 RegDefs.Issue
Supports validation of RegDef V2 files for public cloud registry configuration (AWS, Azure, GCP).
Breaking Change?
V1 RegDefs continue to work unchanged.
Scope / Project
qubership-envgene- RegDef validation ([scripts/build_env/main.py]Implementation Notes
Version detection in [validate_appregdefs()]:
versionfield from RegDef YAML (defaults to "1.0")regdef.schema.jsonfor V1 (version "1.0" or missing)Schema constants:
REGDEF_V1_SCHEMA,REGDEF_V2_SCHEMA,APPDEF_SCHEMAat module levelLogging:
logger.info()for validation messageslogger.debug()for schema selection detailsValidation approach:
Tests / Evidence
Additional Notes
Files Modified:
scripts/build_env/main.pyMigration: V1 RegDefs work as-is. V2 requires adding
version: "2.0"field.RegDef V2 schema (
schemas/regdef-v2.schema.jsonalready exists in repo with support for:authConfigreferences